From 1b11a60accceb7d63a16891863fc0e9abc291de5 Mon Sep 17 00:00:00 2001
From: Josue Zamudio <josuezamudio1@gmail.com>
Date: Sat, 21 Mar 2026 03:13:08 +0000
Subject: [PATCH] Remove client-side game over check to prevent premature game
 end

The client was checking activePlayers.length <= 1 and calling endGame()
prematurely, before the server's authoritative game-over event.

Now the client only ends the game when the server explicitly sends the
'game-over' event.

Added server-side logging to track active player count and winner.
---
 public/js/app.js | 9 ++-------
 server/index.js  | 2 ++
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/public/js/app.js b/public/js/app.js
index 03e120e..e0c0347 100644
--- a/public/js/app.js
+++ b/public/js/app.js
@@ -70,13 +70,8 @@ function setupNetworkListeners() {
       localGame.loadState(localState);
     }
 
-    // Check for game over
-    const allStates = network.getAllGameStates();
-    const activePlayers = Object.values(allStates).filter(s => !s.eliminated);
-
-    if (activePlayers.length <= 1) {
-      endGame(allStates);
-    }
+    // Game over is handled by the server via 'game-over' event
+    // Don't check locally to avoid premature game end
   });
 
   // Game over
diff --git a/server/index.js b/server/index.js
index c3c53a7..96c5b81 100644
--- a/server/index.js
+++ b/server/index.js
@@ -590,7 +590,9 @@ function getStates() {
 
 function checkGameOver() {
   const activePlayers = Array.from(lobby.players.values()).filter(p => !p.eliminated);
+  console.log(`[GAMEOVER CHECK] Active players: ${activePlayers.length} (${activePlayers.map(p => p.name).join(', ')})`);
   if (activePlayers.length <= 1) {
+    console.log(`[GAME OVER] ${activePlayers.length === 1 ? `Winner: ${activePlayers[0].name}` : 'No winner (all eliminated)'}`);
     io.to(LOBBY_ROOM).emit('game-over', { states: getStates() });
     if (lobby.gameInterval) {
       clearInterval(lobby.gameInterval);